SUSE / suse-migration-services

GNU General Public License v3.0
7 stars 11 forks source link

Split out pre-checks from suse-migration-sle15-activation #240

Closed KeithMnemonic closed 2 years ago

KeithMnemonic commented 2 years ago

This PR is the first step towards enhancing the pre-check mechanism included in suse-migration-services. This PR introduces a new package , suse-migration-pre-checks which contains the pre-checks that were previously only included in suse-migration-sle15-activation. This allows users that are only using SLE15-Migration ( kexec) to also be able to use the pre-checks. Prior to this change, users had to install the suse-migration-sle15-activation (reboot) in order to have the pre-checks.

With this change, the suse-migration-pre-checks becomes a prerequisite for SLE15-Migration (and in turn also suse-migration-sle15-activation) The pre-check is run when the suse-migration-pre-checks is installed. Additionally, users can run the pre-check script anytime after installing.

Note: A change to the IBS suse-migration-rpm project will also need to be landed to add suse-migration-pre-checks as a "Requires" for SLE15-Migration rpm package.

Currently, the existing pre-check only produces a warning and does not prevent a migration from being started. For example, if the pre-check warned about an unsupported repo type and a user ignored this, they could still initiate a migration (kexec or reboot) and this check is not run as part of the migration. This will be addressed in a follow up PR describe below.

The next step will be enabling the pre-check as a systemd process in the iso image. This will add the ability to prevent a user from starting a migration if the pre-check fails and also log the failure in the distro_migration.log. Additionally, a new configuration variable can be added (default is False) to allow the migration process to proceed even if the pre-check has failed.

Closes #209