SUSE / suse-migration-services

GNU General Public License v3.0
7 stars 10 forks source link

Add option to skip bind mount entries in fstab #257

Closed KeithMnemonic closed 1 year ago

KeithMnemonic commented 1 year ago

This PR adds a check when reading the fstab file to skip entries whose file system is none. Per the man page of fstab, the third field fs_vfstype is set to "none" for bind or move mounts. By checking for 'none', this allows the suse-migration-pre-checks to run correctly when a fstab has a bind mount entry. Prior to the change, if a bind mount existed, a stacktrace was generated when suse-migration-pre-checks was run.

EXEC: Failed with stderr: (no output on stderr), stdout: (no output on stdout)
Traceback (most recent call last):
  File "/usr/bin/suse-migration-pre-checks", line 11, in <module>
    load_entry_point('suse-migration-services==2.0.35', 'console_scripts', 'suse-migration-pre-checks')()
  File "/usr/lib/python3.4/site-packages/suse_migration_services/prechecks/pre_checks.py", line 81, in main
    check_fs.encryption(migration_system=migration_system_mode)
  File "/usr/lib/python3.4/site-packages/suse_migration_services/prechecks/fs.py", line 39, in encryption
    ["blkid", "-s", "TYPE", "-o", "value", fstab_entry.device]
  File "/usr/lib/python3.4/site-packages/suse_migration_services/command.py", line 117, in run
    command[0], error.decode(), output.decode()
suse_migration_services.exceptions.DistMigrationCommandException: blkid: stderr: (no output on stderr), stdout: (no output on stdout)

In addition, the version was updated.

Bump version: 2.0.35 → 2.0.36