search

SUSE / technical-reference-documentation

SUSE Technical Reference Documentation
https://documentation.suse.com/trd-supported.html
7 stars 22 forks source link

Kevinayres aws mp gsd #54

Closed kevinayres closed 1 year ago

kevinayres commented 1 year ago

Updates to Rancher AWS Getting Started Guide. Work complete and ready for PR.

tlssuse commented 1 year ago

Hi, @dariavladykina, may you please add this document PR to your queue for review?

kevinayres commented 1 year ago

updated authors

tlssuse commented 1 year ago

Thanks for making these changes, @kevinayres . I'll join you in keeping an eye open for any suggestions or questions from @dariavladykina .

tlssuse commented 1 year ago

@dariavladykina : A specific version of Rancher is not mentioned. This is because the offering in the AWS Marketplace uses the latest stable release of Rancher. This means that the product version will change frequently, even though the offering and the way it works (as described in this document) does not. As a result, we deviated from our normal practice of identifying specific versions.

At the time of this writing, the specific version of Rancher is 2.6.10, but the next update (which should be something like, 2.7.x) would not affect the content of the current document.

I'm happy to hop on a call to discuss this further.

kevinayres commented 1 year ago

Updated authors, variables.

tlssuse commented 1 year ago

@dariavladykina & @tomschr : This document is ready to merge. If you concur, please do so and publish.

tomschr commented 1 year ago

I'm basically okay with all, but there is one thing that I'd like to get fixed. This PR contains .DS_Store files. They are binary, MacOS specific, and shouldn't be included. Could you remove them, please?

Once that's done, I'll squash the commits and it's ready to build.

tlssuse commented 1 year ago

@tomschr : Thanks for catching this. I believe I have found all the .DS_Store files and removed them.

tomschr commented 1 year ago

Thanks @tlssuse! Looks fine, I'll merge it in a minute. :+1:

tomschr commented 1 year ago

@tlssuse Unfortunately, I just saw that I can't select the "Squash and merge" option for this repo. I think it would be really helpful to squash the commits to have a clean history. Otherwise we would end up with 50+ commits.

It can be enabled in the "Settings" tab under "General" -> "Pull Requests" and check the "Allow squash merging" box. Maybe that was on purpose, but I don't know.

Basically we have these options:

  1. I could enable the option in the setting for you, or
  2. Someone squashes the commits manually, or
  3. Leave it as is and merge it.

I don't want to impose any workflow on you, that's why I'm asking. But in my humble opinion having a good history is a good thing.

What do you prefer? :slightly_smiling_face:

tlssuse commented 1 year ago

Hi, @tomschr : Thank you. I think we should squash the commits. @kevinayres , since this is your fork, do you want to give it a try?

tomschr commented 1 year ago

Ahh sorry, I was a bit too fast. It's merged now. :see_no_evil:

tomschr commented 1 year ago

It's available now at https://docs.suse.com/trd/kubernetes/html/gs_rancher_aws-marketplace/index.html