search

SUSE / technical-reference-documentation

SUSE Technical Reference Documentation
https://documentation.suse.com/trd-supported.html
7 stars 22 forks source link

GS metadata template updates #98

Closed tlssuse closed 1 year ago

tlssuse commented 1 year ago

Hi, @chabowski, @bwgartner, @tomschr, @janajaeger: In this PR I have updated the SUSE TRD getting started templates to include the new/updated metadata tags we have discussed. This PR also includes updates to the GS setup script, adding many more sanity checks and clearer instructions.

The templates can be found in the common/templates/start directory. The metatags are implemented in the _docinfo-file with variable definitions in the _adoc-file.

I welcome your review and feedback.

~ Terry

chabowski commented 1 year ago

So @tlssuse I assume I should wait with merging until the changes are done? Thank you

tlssuse commented 1 year ago

Yes, please hold on merging. I will submit changes later today.

tomschr commented 1 year ago

Yes, please hold on merging. I will submit changes later today.

@tlssuse As a tip: when I create a pull request and it's not ready yet, I set it to draft. It's a bit hidden, but you can find it in the right sidebar under the list of reviewers. Look for "Still in progress?" and click the "Convert to draft" link. Done. :wink:

tlssuse commented 1 year ago

Thank you, @tomschr ... I was wondering where to find the 'draft' option. Done.

tlssuse commented 1 year ago

@chabowski: I have made some changes based on the feedback I received (thank you).

I expect to continue to evolve these files, but, for now, I think these can be merged into upstream/main.

~ Terry