search

SUSE / velum

Dashboard for CaaS Platform clusters (v1, v2 and v3)
https://www.suse.com/
Apache License 2.0
54 stars 30 forks source link

[3.0] Add a feature spec for building cluster in Azure #588

Closed bear454 closed 6 years ago

bear454 commented 6 years ago

Backport of #584 .

bear454 commented 6 years ago

Add a feature spec for building cluster in Azure

bear454 commented 6 years ago

@MaximilianMeister can it be merged in along with something consequential? I agree it's rather trivial, but since I'll be adding the same for GCE shortly, all the way back to 2.1... It seemed important to include ;-)

Maybe this warrants starting the release-3.1 branch for public cloud? cc @jordimassaguerpla

jordimassaguerpla commented 6 years ago

@bear454 : We need a bsc number to port fixes to this branch. I would say, if this goes along with a bug fix, then I am fine to merge this after we have release 3.0, so this is shipped as a maintenance updates. Right now we are only merging P1 fixes, but we will open the gates again in short.

Have in mind, a bug fix could also be "enabling integration with Azure cluster".

bear454 commented 6 years ago

@jordimassaguerpla I'm fine with waiting a while to merge this in... there's no rush on it.

vitoravelino commented 6 years ago

I guess this is good to be merged since the release is out.

vitoravelino commented 6 years ago

Oh, there's no bsc number. =/

bear454 commented 6 years ago

vitoravelino commented 5 days ago

Oh, there's no bsc number. =/

This doesn't solve a "bug" - there is currently no known defect; just an effort to provide proper testing framework consistently across all environments; e.g. this is an enhancement but is not user-facing.

vitoravelino commented 6 years ago

This doesn't solve a "bug" - there is currently no known defect; just an effort to provide proper testing framework consistently across all environments; e.g. this is an enhancement but is not user-facing.

I know, you already have my +1. I guess using enhancement#azure-spec would solve the backport rule. Just guessing...

bear454 commented 6 years ago

bear454 dismissed vitoravelino’s stale review

Well, github dismissed the review when I changed the commit message... I didn't do anything with reviews ;-)

jordimassaguerpla commented 6 years ago

@MaximilianMeister : It is ok to merge this one. Our package excludes files under spec directory and this can be useful when looking for regressions for new commits into 3.0 branch,