Introduce admission webhook settings page

[flavio]

Allow user to enable AdmissionWebhook by using a new dedicated page.

To work this requires the following PR merged into the salt repo: https://github.com/kubic-project/salt/pull/555

The new UI has to be improved by @vitoravelino, right now it looks something like that:

The workflow is the following one:

• go this new page
• upload key and certificate
• enable the feature
• deploy the cluster

Notable things missing:

• [X] Validate input (required)
• [X] Fix UI
• [X] Add tests
• [x] Fix coverage

[vitoravelino]

Current state with last commit:

[vitoravelino]

@flavio This is good to be reviewed.

[flavio]

It looks to me, I like the workflow. However there's a bug:

• upload key and cert
• save
• disable the feature
• save -> accept the warning message from the popup window
• reload the page
• enable the feature -> the old key and cert are still shown

Basically we don't actually delete them from the database.

[flavio]

Also another bug: it's possible to upload empty files. The validation in place doesn't look for that

[vitoravelino]

Fixed both cases, @flavio. Thanks!

[vitoravelino]

[flavio]

I cannot be the one approving the PR because I'm the one who created it. But it LGTM

[vitoravelino]

I guess we can proceed with the merge, right? I'll give my approval on behalf of @flavio since he created the PR and can't do that.

[vitoravelino]

I updated the code with with the x509 validation and added pem/der key format validation. Suggestion for wording are welcome. I also made a minor refactoring to make things more readable.

Please review it again. Thanks!

@flavio, could you play with this again?

[bergmannf]

Just a short update to fix the merge conflicts. I still intend to setup an admission webhook and actually try out the code.

[vitoravelino]

Just a short update to fix the merge conflicts. I still intend to setup an admission webhook and actually try out the code.

I don't see any conflicts. Is something going to change?

[bergmannf]

Sorry - I just meant I repushed the changes after a rebase due to conflicts in app/controllers/internal_api/v1/pillars_controller.rb - the dex connector apparently added some more pillars.

[vitoravelino]

I've rebased this and should be good to be reviewed again.

[bergmannf]

LGTM with one small change (use fixture_file_upload).

However given that the salt PR is on hold I don't think we can merge this right now.

[MalloZup]

This GitHub PR is unactive since 30. Is this GitHub PR still needed? Please close or update it accordingly. This reminder is autogenerated by https://github.com/MalloZup/blacktango