save online status through reconciler (bsc#1098436)

[MaximilianMeister]

when a minion is down, it should be shown as down in the UI

Signed-off-by: Maximilian Meister mmeister@suse.de

[vitoravelino]

I don't think a question mark is the best icon to indicate that a minion is down.

[ereslibre]

I was thinking in other ways of doing this, but your solution looks really nice and easy. It's a +1 from me.

[ereslibre]

As per @vitoravelino's comment, maybe we can add another (on|off)line indicator in the UI, showing the "status" of the minion as we also show the "applied/applying/not applied" status?

[vitoravelino]

As per @vitoravelino's comment, maybe we can add another (on|off)line indicator in the UI, showing the "status" of the minion as we also show the "applied/applying/not applied" status?

Does it make sense to show "failed and offline", "applied and offline" and "not applied and offline"?

I thought about the opaque circle in gray to represent offline. What do you think?

[MaximilianMeister]

I've changed the layout a bit now to have 2 extra columns, probably some tests need to be adapted now ...

I thought about the opaque circle in gray to represent offline. What do you think?

can you provide the fontawesome identifier for me?

[MaximilianMeister]

@ereslibre other question, should we also disable the remove link when a node is down, or is that independent?

[Martin-Weiss]

It would be cool if the icon / text for for an offline minion that does not respond for a while could indicate something like "last seen ... minutes / hours / days ago" or at least provide the information as "mouse over" after which time a minion is marked as "offline" would be great.

[MaximilianMeister]

@Martin-Weiss thanks for the feedback, i've added a tooltip now with last updated at: timestamp

[MaximilianMeister]

Cool! Just to be sure to be sure - the timesstamp displayed is the "admin server UTC time" or is it the "browser local time"?

it's data from the back-end (rails database), so should be admin server time

[Martin-Weiss]

Would it be possible to add the info („time displayed is admin server time“) to the UI?

[MaximilianMeister]

Would it be possible to add the info („time displayed is admin server time“) to the UI?

added

[vitoravelino]

I've changed the layout a bit now to have 2 extra columns, probably some tests need to be adapted now ...

I'd move the online column to the left since there's text regarding the applied column sometimes.

can you provide the fontawesome identifier for me?

Since you've created another column, I'd go with something like

Online: fa-circle (green) Offline: fa-circle (gray/red)

Not sure if it's ideal but let's see how it looks.

[vitoravelino]

Nodes are marked as offline while they are being bootstrapped:

I guess they should be online, right?

[MaximilianMeister]

I guess they should be online, right?

right

hmm, i think this is due to the default online: false - we could either set it to true or we need to run Minion.update_grains before bootstrap

setting it by default to true would make sense i guess, because the moment when the minion is created (in the db), we can assume at this point it is online

[MaximilianMeister]

we have the same issue here as explained in https://github.com/kubic-project/velum/pull/585#discussion_r198378403 so jenkins will likely not be seen green before merging this

[flavio]

I know I'm late, but what about having a single column "status" that shows:

• green checkmark (online + updated),
• something spinning (online + upgrading)
• red: online, update failed
• another color (orange?), whole row "disabled": offline, unknown state

[flavio]

I spoke with @MaximilianMeister, he got approval from the UX team about the current proposal. Hence you get my :+1: on the proposed UI/UX