SUSE / velum

Dashboard for CaaS Platform clusters (v1, v2 and v3)
https://www.suse.com/
Apache License 2.0
54 stars 30 forks source link

[3.0] Public Cloud: Add support for bootstrapping in Google Compute #596

Closed bear454 closed 6 years ago

bear454 commented 6 years ago

(cherry picked from commit 446f412a3fd871bfae8429d9131fe462cbbb0d5e)

bear454 commented 6 years ago

Public Cloud: Add support for bootstrapping in Google Compute

MaximilianMeister commented 6 years ago

@bear454 can you make sure to get the tests green here?

bear454 commented 6 years ago

Sorry @MaximilianMeister - I thought product_name was defined for 3.x.

MaximilianMeister commented 6 years ago

LGTM :+1:

@jordimassaguerpla is it ok like this or should we squash the commits or add the bug reference to the 2nd commit as well? in jenkins we test that every backport commit has a bug reference.

@bear454 feel free to squash the commits, or add the bug reference to the 2nd commit

MaximilianMeister commented 6 years ago

I thought product_name was defined for 3.x.

yeah as we havent backported the branding this was not really obvious

jordimassaguerpla commented 6 years ago

Please make sure all commits have a bsc number, either squash or reedit the commit message. Thanks.

bear454 commented 6 years ago

I've squashed the commit, but there's no bugzilla entry for adding public cloud support, @jordimassaguerpla .

@MaximilianMeister , please reset your review; github removed it when I squashed the commit.

jordimassaguerpla commented 6 years ago

@bear454 : fine with me. We will figure out during the packaging process if we have to add some reference.

bear454 commented 6 years ago

Rebased, and added in the necessary fixes for BSC#1098085, as @kiall requested.

bear454 commented 6 years ago

Bug 1098085 - No UI for accessing node bootstrap info after setup

kiall commented 6 years ago

@MaximilianMeister - can you double check? Should be good to go though.