Closed bear454 closed 6 years ago
@bear454 can you make sure to get the tests green here?
Sorry @MaximilianMeister - I thought product_name
was defined for 3.x.
LGTM :+1:
@jordimassaguerpla is it ok like this or should we squash the commits or add the bug reference to the 2nd commit as well? in jenkins we test that every backport commit has a bug reference.
@bear454 feel free to squash the commits, or add the bug reference to the 2nd commit
I thought product_name was defined for 3.x.
yeah as we havent backported the branding this was not really obvious
Please make sure all commits have a bsc number, either squash or reedit the commit message. Thanks.
I've squashed the commit, but there's no bugzilla entry for adding public cloud support, @jordimassaguerpla .
@MaximilianMeister , please reset your review; github removed it when I squashed the commit.
@bear454 : fine with me. We will figure out during the packaging process if we have to add some reference.
Rebased, and added in the necessary fixes for BSC#1098085, as @kiall requested.
@MaximilianMeister - can you double check? Should be good to go though.
(cherry picked from commit 446f412a3fd871bfae8429d9131fe462cbbb0d5e)