search

SUSE / velum

Dashboard for CaaS Platform clusters (v1, v2 and v3)
https://www.suse.com/
Apache License 2.0
54 stars 30 forks source link

Certificate validation #600

Closed bergmannf closed 6 years ago

bergmannf commented 6 years ago

Fixes bsc#1097754: a certificate's text will be verified to be a X509 certificate.

bergmannf commented 6 years ago

(3) M - Bug 1097754 - Certificates are not validated

vitoravelino commented 6 years ago

rest LGTM, however we should also check if we still need the old cert fixtures in https://github.com/kubic-project/velum/tree/master/spec/fixtures and if not, drop them

I've used the the admin.key and admin.crt in #590 since they were already there.

bergmannf commented 6 years ago

@vitoravelino In some of the tests we need two different certificates - that's why I added another set, to test updating we now need two valid certificates.

Maybe it would be better to make the factory classes generate more than 1 certificate instead and then just use those instead.