Closed chentex closed 5 years ago
I resolved all tour comments @vitoravelino , I had to do some minor changes but it works as expected. The thing I could not manage to do is to keep the Add button disabled, at the first refresh it'll activate again.
Edit: Working on the test scenarios.
The Next
button was being enabled after a few seconds, that was because of the handleBootstrapErrors
method.
You can add something like
if (State.pendingRemovalMinionId) {
return;
}
to avoid enabling the next button while a removal is happening.
@vitoravelino I tried adding the lines to disable and enable the next button but it messes with the minions lists and they stop showing anything
@MaximilianMeister here is the Screen Shot for the discovery step.
Done with your comment @MaximilianMeister
Shouldn't we backport that to the 3.0 branch?
This adds the possibility to remove an unassigned node, from the assign_nodes page. I also added a reject node link to the unassigned nodes, seemed to me that that functionality was missing. *The setup step discovery can also do this.
CATCH/HELP: There is a time between when the remove node it's clicked and accepted and when the salt event removes that node from the DB, that the user could assign that node to a role and apply the changes, that leaves the cluster in an unstable state. If someone could help me to figure this out I would appreciate it, maybe disabling it via JS or something, don't know the correct way to approach it.