search

SUSE / velum

Dashboard for CaaS Platform clusters (v1, v2 and v3)
https://www.suse.com/
Apache License 2.0
54 stars 30 forks source link

Add global orchestration indicator #653

Closed ereslibre closed 5 years ago

ereslibre commented 5 years ago

This allows us to mark machines as succeeded as soon as we know the highstate on that machine succeeded, providing a better timely feedback to the user.

Fixes: bsc#1064610

vitoravelino commented 5 years ago

After playing a bit, I thought about these styles

screenshot-20180911072556-956x179 screenshot-20180911072613-953x178 screenshot-20180911072625-954x171 screenshot-20180911072639-953x176 screenshot-20180911072654-955x172

What do you think?

ereslibre commented 5 years ago

What do you think?

I like it, I didn't think about that spot!. I think I'm more towards the red Failed and green Succeeded text.

vitoravelino commented 5 years ago

@ereslibre answering your question from IRC: yes, the fix was merged and a simple rebase makes everything green. :smiley:

ereslibre commented 5 years ago

This needs to pass CI, I will fix this.

vitoravelino commented 5 years ago

@MalloZup why did you close it?

MalloZup commented 5 years ago

sorry @vitoravelino the PR was stale. feel free to reopne if you need it :+1:

vitoravelino commented 5 years ago

I'll try to fix the conflicts and make this mergeable again. Thanks!

MalloZup commented 5 years ago

:cupid: