Closed vitoravelino closed 5 years ago
The changes are much cleaner than the method I did previously. I agree that they are an improvement. I still don't understand why the id has to be on the label instead of working on the actual input fields. That does not make sense to me. I would like to know if a full manual test has been done to ensure the page still works from a sanity perspective.
It certainly does look cleaner and more correct in regards to Ruby. Pointing to the label does feel more like a 'trick' to me than it should, but better than mixed languages.
Signed-off-by: Vítor Avelino vavelino@suse.com