search

SUSE / velum

Dashboard for CaaS Platform clusters (v1, v2 and v3)
https://www.suse.com/
Apache License 2.0
54 stars 30 forks source link

rebase patch #661

Closed MaximilianMeister closed 5 years ago

MaximilianMeister commented 5 years ago

Signed-off-by: Maximilian Meister mmeister@suse.de

MaximilianMeister commented 5 years ago

probably introduced by https://github.com/kubic-project/velum/pull/650

jordimassaguerpla commented 5 years ago

You need to update the patch file. All you need to do is create a patch that, when applied to the db/schema.rb, it does modification:

You only have to do this if you are adding a new database migration.

bear454 commented 5 years ago

Why is this carried as a patch? Why not just adjust the schema, through migration if necessary, to apply that change?

bear454 commented 5 years ago

https://stackoverflow.com/questions/1580805/how-to-set-the-default-value-for-a-datetime-column-in-migration-script

jordimassaguerpla commented 5 years ago

@bear454 Didn't we already discussed that :) ?

https://github.com/kubic-project/velum/pull/515#issuecomment-387800205

Feel free to create a PR to fix it :)

bear454 commented 5 years ago

Alright, then. #666 :smiling_imp: