search

SUSE / velum

Dashboard for CaaS Platform clusters (v1, v2 and v3)
https://www.suse.com/
Apache License 2.0
54 stars 30 forks source link

[bsc#1109720] test for salt 'alter_time' attributes #666

Closed bear454 closed 5 years ago

bear454 commented 5 years ago

Incorporate the alter_time patch into the schema by default, and test that conditions are met.

Instead of having to remember to update a non-obvious patch when adding a migration, developers must remember not to include changes to the affected schema lines, and will be assisted by a spec that verifies the proper conditions are maintained.

BONUS: test for the conditions without analyzing the text content of the schema file, so that whenever velum moves to Rails 5, we can incorporate the proper upstream implementation[1]

[1] https://stackoverflow.com/a/40647191

bear454 commented 5 years ago

Bug 1109720 - Development which modifies velum's database schema requires updating a non-obvious patch

flavio commented 5 years ago

@MaximilianMeister can you take a look at that please?