search

SUSE / velum

Dashboard for CaaS Platform clusters (v1, v2 and v3)
https://www.suse.com/
Apache License 2.0
54 stars 30 forks source link

[3.0] ui: don't show failed alert for repeated orchestration #681

Closed MaximilianMeister closed 5 years ago

MaximilianMeister commented 5 years ago

A failed alert is shown whenever one of the nodes fails to bootstrap. This is an optimization to only show this alert once for a specific orchestration run. If the user closes the alert, it won't come back unless a new orchestration happens.

bsc#1097752

Signed-off-by: Vítor Avelino vavelino@suse.com (cherry picked from commit e943e073e813cdea58bf0943e1caba226cb60131)

Backoprt of https://github.com/kubic-project/velum/pull/589

ereslibre commented 5 years ago

How much would break if the column type was changed?

As far as I can tell MariaDB should not be mapping timezones at all. We control how we run MariaDB and we should not be setting any timezone in it. On top of that, ActiveRecord should be using UTC for all our usages (because we are not mapping them either), so I don't see a timezone shift in any part of the stack (we can ask for the customer timezone in the future and show events on the views to their local time, but that's up on the stack, MariaDB and ActiveRecord should be storing everything in plain UTC).

By default Rails creates created_at and updated_at as datetime instead of timestamp. I think it would be good if we could continue using Rails' defaults.

ereslibre commented 5 years ago

Not adding the awaiting-merge label until @dannysauer confirms that everything is fine regarding their objections.