SUSE / velum

Dashboard for CaaS Platform clusters (v1, v2 and v3)
https://www.suse.com/
Apache License 2.0
54 stars 30 forks source link

Velum: Add more log filters for user's secrets, pass, and tokens #685

Closed suseclee closed 5 years ago

suseclee commented 5 years ago

Velum uses pass, password, and bind_pw symbols accordingly. Diverse symbols in velum are exposed in Velum logs. After symbols were added in log filters, logs in admin:/var/log/containers will shows:

{"log":"Processing by SetupController#configure as HTML\n","stream":"stdout","time":"2018-10-18T00:37:42.923336515Z"} {"log":" Parameters: {\"utf8\"=\u003e\"✓\", \"authenticity_token\"=\u003e\"[FILTERED]\", \"settings\"=\u003e{\"dashboard\"=\u003e\"10.17.1.0\", \"tiller\"=\u003e\"false\", \"cluster_cidr\"=\u003e\"172.16.0.0/13\", \"cluster_cidr_min\"=\u003e\"172.16.0.0\", \"cluster_cidr_max\"=\u003e\"172.23.255.255\", \"cluster_cidr_len\"=\u003e\"23\", \"services_cidr\"=\u003e\"172.24.0.0/16\", \"api_cluster_ip\"=\u003e\"172.24.0.1\", \"dns_cluster_ip\"=\u003e\"172.24.0.2\", \"enable_proxy\"=\u003e\"disable\", \"http_proxy\"=\u003e\"\", \"https_proxy\"=\u003e\"\", \"no_proxy\"=\u003e\"localhost, 127.0.0.1\", \"proxy_systemwide\"=\u003e\"false\", \"suse_registry_mirror_enabled\"=\u003e\"disable\", \"suse_registry_mirror\"=\u003e{\"url\"=\u003e\"\", \"certificate\"=\u003e\"[FILTERED]\"}, \"suse_registry_mirror_certificate_enabled\"=\u003e\"[FILTERED]\", \"container_runtime\"=\u003e\"docker\", \"system_certificate\"=\u003e\"[FILTERED]\"}, \"commit\"=\u003e\"Next\"}\n","stream":"stdout","time":"2018-10-18T00:37:42.923397952Z"}

MaximilianMeister commented 5 years ago

@suseclee can you add bsc#1111848 to the commit message? this is the format we need for our build service tooling to recognize it

the change itself LGTM :+1:

suseclee commented 5 years ago

@MaximilianMeister I added bsc#1111848 to the commit message.

MaximilianMeister commented 5 years ago

@suseclee can you open a backport pull request to the release-3.0 branch please? as the bug is filed for CASP v3