search

SUSE / velum

Dashboard for CaaS Platform clusters (v1, v2 and v3)
https://www.suse.com/
Apache License 2.0
54 stars 30 forks source link

[WIP] Added External Certificates Feature #707

Closed danielorf closed 5 years ago

danielorf commented 5 years ago

Added External Certs controller to Settings; Added associated views, routes and models Added ext_cert_feature_spec.rb, added example certs/keys to spec/fixtures

danielorf commented 5 years ago

The last remaining piece is to fill in the trust_chain_verify method. This will follow in another PR shortly.

vitoravelino commented 5 years ago

Regarding the mirrors/registries specs failing, you can remove expect(page).not_to have_content("Certificate") lines that it's causing that. No big deal.

danielorf commented 5 years ago

Regarding the mirrors/registries specs failing, you can remove expect(page).not_to have_content("Certificate") lines that it's causing that. No big deal.

I had to change a few tests (mirrors_feature_spec and registries_feature_spec) because they were looking for "Certificate" on the page which contains the word twice in the sidebar.

vitoravelino commented 5 years ago

screenshot-20190109145254-352x84

screenshot-20190109145455-232x67

I'm fine with Valid Key: true and true being green but the other case should be black.

danielorf commented 5 years ago

@vitoravelino All of your comments should be addressed now.

danielorf commented 5 years ago

I am stripping out the expect(page).to have_http_status(:success) from the tests where this comes first. There appears to be a race condition where Capybara sometimes detects the redirect (30X) and not the following successful http status (20X).

danielorf commented 5 years ago

Screenshot of current state with a sample cert uploaded for Velum: image

danielorf commented 5 years ago

Moving this work to a feature branch (feature_external_certs) to better manage commits from multiple users and keep history clean.