search

SUSE / velum

Dashboard for CaaS Platform clusters (v1, v2 and v3)
https://www.suse.com/
Apache License 2.0
54 stars 30 forks source link

Remove gem-install workaround #711

Closed MalloZup closed 5 years ago

MalloZup commented 5 years ago

Description:

this is a backport from https://github.com/kubic-project/velum/pull/709

Don't run gem update --system

Related to gem update --system:

hwoarang commented 5 years ago

@hwoarang i was asked to the backport. Initially the fix was in master.

You can see travis-ci/travis-ci#8978 and in this commit description plataformatec/devise@8e49661

I understand this is a backport but that does not mean the commit message has to be cryptic. Since we can't fix the commit message on master anymore lets fix this instead.

I would prefer it if you amend you commit message to explain the problem and the solution.

MalloZup commented 5 years ago

one thing to investigate, is why this is failing only on 3.0 and not on velum head. https://travis-ci.org/kubic-project/velum/jobs/477778826, and also why only for that ruby version

MalloZup commented 5 years ago

Yep sure. Before squashing I think we need agreement what we do with the version, should we increment it and do the same in master? Is OK for everybody?

flavio commented 5 years ago

I have nothing against dropping this version of ruby, as far as I can see both v3 and v4 are using ruby 2.1.9, which is still being tested by travis.

Maybe others more involved with velum can express their opinion on the topic?

MalloZup commented 5 years ago

@ereslibre @MaximilianMeister if it is of for you, we can stick to that version and before merging this PR i will send also a PR to head branch so we have 1:1 along branches. TIA. :motor_scooter:

MaximilianMeister commented 5 years ago

We still have ruby 2.1.9 in v4 so we don't need to test 2.2 i'd say

MalloZup commented 5 years ago

thx @MaximilianMeister feel free to merge theb tgx