search

SUSE / velum

Dashboard for CaaS Platform clusters (v1, v2 and v3)
https://www.suse.com/
Apache License 2.0
54 stars 30 forks source link

[bsc#1126208] Do not block updates on minions #734

Closed bear454 closed 5 years ago

bear454 commented 5 years ago

https://github.com/kubic-project/velum/pull/704 inadvertently blocked an excessive amount of functionality. This went unnoticed as the function remove_minion was intended to be blocked; the functions add_minion and reject_minion do not apply in the public cloud (minions are automatically joined to the salt cluster by salt-cloud), leaving the update function... which has no comment or clarification in the source or specs that it is the trigger for an action unrelation to the other functions in this scope.

bear454 commented 5 years ago

[bsc#1126208] Do not block updates on minions

spiarh commented 5 years ago

I have tested the fix and I've managed to update all the nodes and add nodes.

danielorf commented 5 years ago

Moved PR to https://github.com/SUSE/kubic-velum-security-fixes/pull/13