search

SVG-Edit / svgedit

Powerful SVG-Editor for your browser
MIT License
6.45k stars 1.53k forks source link

connector bug #305

Open enlove opened 5 years ago

enlove commented 5 years ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. open link "...?lang=zh-CN"
  2. draw 2 circles
  3. select connector,connect 2 circles
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

SVG-Edit environment (IMPORTANT)

Desktop (please complete the following information):

consoleoutput Lang: zh-CN svgedit-config-iife.js:28384 Uncaught TypeError: Cannot read property 'showGrips' of null svgedit-config-iife.js:14162 at SvgCanvas.addToSelection.addToSelection (svgedit-config-iife.js:14162) at SvgCanvas.selectOnly.selectOnly (svgedit-config-iife.js:15172)

enlove commented 5 years ago

console.log

svgedit-config-iife.js:14162 Uncaught TypeError: Cannot read property 'showGrips' of null svgedit-config-iife.js:28342 Lang: zh-CN svgedit-config-iife.js:36054 Uncaught (in promise) TypeError: Cannot read property 'runExtension' of undefined 4svgedit-config-iife.js:28342 Lang: zh-CN svgedit-config-iife.js:28342 Lang: zh-CN svgedit-config-iife.js:28342 Lang: zh-CN

Symbols '-' is illegal in js ? global replace '-' with '_'?

brettz9 commented 5 years ago

I am not able to replicate in 4.1.0 (e.g., at https://svg-edit.github.io/svgedit/releases/svg-edit-4.1.0/editor/svg-editor.html?lang=zh-CN ). Are you sure you are testing against that version?

enlove commented 5 years ago

yes，version 4.1.0

enlove commented 5 years ago

https://pan.baidu.com/s/1h6qblu3hSiafntm0V3Blqg

screenshot

brettz9 commented 5 years ago

Can you replicate on https://svg-edit.github.io/svgedit/releases/svg-edit-4.1.0/editor/svg-editor.html?lang=zh-CN ?

enlove commented 5 years ago

yes, i have replicated 2 minutes ago on https://svg-edit.github.io/svgedit/releases/svg-edit-4.1.0/editor/svg-editor.html?lang=zh-CN

At 2018-11-30 16:29:17, "Brett Zamir" notifications@github.com wrote:

Can you replicate on https://svg-edit.github.io/svgedit/releases/svg-edit-4.1.0/editor/svg-editor.html?lang=zh-CN ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

enlove commented 5 years ago

my be i found the reason, i open 2 links in a browser.

another bug:

At 2018-11-30 16:29:17, "Brett Zamir" notifications@github.com wrote:

Can you replicate on https://svg-edit.github.io/svgedit/releases/svg-edit-4.1.0/editor/svg-editor.html?lang=zh-CN ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

brettz9 commented 5 years ago

You found another bug? It didn't come through...

enlove commented 5 years ago

another bug i replied to your email, pic can't display here.

brettz9 commented 5 years ago

Reposting @enlove's screenshots and comments:

Sorry, what do you mean "draw out it"? drag out

image-1

once open more than 1 editsvg tab ，Only the last one connector is working 。

image

enlove commented 5 years ago

bug 1：open 2 tab （editsvg） in a browser ，only the last one tab's 'connector' plugin is working.

bug 2：open layer view on the right，drag a menu onto the canvas ，layer view will not display properly

brettz9 commented 5 years ago

I've added #306 on your behalf for bug 2. In the future, please file separate issues. Thanks for the reports!