Fix memory corruption, related to unitialized currentPlay

SVModular / DrumKit

Drum modules for VCVRack

Other

42 stars 3 forks source link

Fix memory corruption, related to unitialized currentPlay #16

Open falkTX opened 2 years ago

falkTX commented 2 years ago

Under certain conditions, loading a project with DrumKit Sequencer on it would cause a crash. Main issue seems to be that currentPlay is not initialized during constructor, so random stuff would just go wrong..

See related discussion at https://github.com/DISTRHO/Cardinal/issues/225

Patch fixes the crash, reordering some minor things for looking better and also in a way that makes sense.

JerrySievert commented 2 years ago

thanks! I still have been unable to reproduce the issue on macOS. I will give this a run in the next day or so and merge if it looks good.