SVModular / SynthKit

Synth Kit for VCV Rack
Creative Commons Zero v1.0 Universal
33 stars 5 forks source link

No resets? #4

Closed bubbleandsquawk closed 6 years ago

bubbleandsquawk commented 6 years ago

It seems that among all of your clock related and clock dependent modules there is a lack of resets. I have to wonder if this is intentional or an oversight?

JerrySievert commented 6 years ago

oversight. can add for the next release.

bubbleandsquawk commented 6 years ago

Nice! Thanks!

JerrySievert commented 6 years ago

I've been trying to figure out exactly where to put the reset ... I may end up switching jack components to something smaller (like in CharredDesert), in order to better fit it in.

when I wrote the underlying code to handle everything SynthDevKit, I included resets in everything, so it really is just a matter of hooking it up.

I'll see how much work it will be to convert over to the smaller jacks, and see how it looks, and let you know when reset is live.

bubbleandsquawk commented 6 years ago

The 4ms modules (RCD and SCD) seem to find sufficient lateral space for an extra socket, and 4hp seems to be enough space to squeeze two sockets side by side.

I'm sure you'll figure it out. :)

JerrySievert commented 6 years ago
screen shot 2018-04-06 at 12 59 54 pm

2 across, no problem - 3 across and labels not so fun :)

screen shot 2018-04-06 at 1 00 45 pm
jonheal commented 6 years ago

I don't if you noticed it or not, Jerry, but yesterday, I took the liberty of working up a design for your Rotating Clock Divider. Then I realized I kind of had my paradigm backwards for how IN vs. OUT jacks are typically identified so I deleted my post. Since this was unsolicited to begin with, I wondered if I should just stay quiet. But I couldn't resist, and I reworked the design(s). They obviously depart from the 4MS look, but if you like these, I would be willing to work up designs for the remaining members of the "SynthKit" line of modules. If not, ignore. :-)

dk-dividers

bubbleandsquawk commented 6 years ago

I'm a big fan of that design Jon. Nice work.

jonheal commented 6 years ago

One more ...

sk-logic-and

JerrySievert commented 6 years ago

thanks @jonheal ! they look great!

any chance I can get you to try them using the components that SynthKit uses? see https://github.com/JerrySievert/rack-components for the selection.

colors are easy to change on them, but I prefer the look and feel.

jonheal commented 6 years ago

Here is the AND module from above using your small gray jacks:

sk-logic-and-sk-components

For the Divider CV, I must say I am partial to my own knurled small knob. :-) Ruminate on it for a while. Maybe it will grow on you.

jonheal commented 6 years ago

A big version:

sk-logic-and-sk-components-big

jonheal commented 6 years ago

The Divider CV (100% and magnified) with resized bits for your jacks, but still including my knurled knobs:

sk-rotating-clock-divider-cv-sk-components

JerrySievert commented 6 years ago

3out

you can see the knob difference here. (well, a hack job of it)

JerrySievert commented 6 years ago

non

less of a hack job.

jonheal commented 6 years ago

Would you be open to toning down the black on the knobs a little? As the only jet black objects on the panel, I think it is too jarring.

-- Jon Heal http://www.theheals.org/ Have a nice day!


From: "Jerry Sievert" notifications@github.com Sent: Thursday, May 10, 2018 1:33 PM To: "JerrySievert/SynthKit" SynthKit@noreply.github.com Subject: Re: [JerrySievert/SynthKit] No resets? (#4)

less of a hack job.

- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

JerrySievert commented 6 years ago

yes, absolutely. agree with the jarring jet black. happy to tone it down to whatever, it's easy to add another set of knobs to the repo that's included.

jonheal commented 6 years ago

I can work on it when I get home from work. -- Jon Heal http://www.theheals.org/ Have a nice day!


From: "Jerry Sievert" notifications@github.com Sent: Thursday, May 10, 2018 2:07 PM To: "JerrySievert/SynthKit" SynthKit@noreply.github.com Subject: Re: [JerrySievert/SynthKit] No resets? (#4)

yes, absolutely. agree with the jarring jet black. happy to tone it down to whatever, it's easy to add another set of knobs to the repo that's included.

- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

JerrySievert commented 6 years ago

awesome. it's easy for me to just do a copy and set the colors, as long as the colors are defined. I mean, those svg's were originally programmatically generated, then loaded into Inkscape to get rack to figure them out. I know my way around them by now :)

jonheal commented 6 years ago

And you are willing to shrink your buttons as you have done in the mockup example?

JerrySievert commented 6 years ago

yeah, if the "small" versions don't fit, I'm happy to shrink them until they do - as I said, built programmatically, so not too big of a deal.

JerrySievert commented 6 years ago

also can change the jack outer ring to match the same black as the knobs.

jonheal commented 6 years ago

Two other things:

  1. What is the largest value the knobs would reach? Right now, there is not room for three digits. if you wanted to go to 128 like the Doepfer device, I would need to do some more squishing.
  2. I used commercial fonts, which is not a big deal for most of the text on the panels because I would just turn it into outlines, but I would assume those changing number values would need to remain as a font, so I need to find an equivalent font that can be redistributed for those numbers.
JerrySievert commented 6 years ago

sequencers: 0-8 and 0-11.

(octave for 0-8, and note for 0-11)

jonheal commented 6 years ago

I switched to a Google font: Teko. Can you live with two different jacks? The jacks on a dark background need a light ring, I think.

sk-rotating-clock-divider-cv-sk-components

My one comment is that I think it would improve the look of your knobs at 100% (on a non-retina monitor) if the inner circle was shrunk just a bit to expose a bit more of the yellow ring. The yellow kind of gets lost in pixelization at 100%. I will make an example when I get home today.

jonheal commented 6 years ago

A subtle difference, but meaningful, I think:

sk-rotating-clock-divider-cv-sk-components

JerrySievert commented 6 years ago

shrunk the inner circle locally - can you send an SVG of one of the designs, so I can throw something together programmatically to see a final result?

jonheal commented 6 years ago

Now ... hopefully this won't cause problems, but I use Affinity Designer, not Inkscape. There are lots of SVG export options in Designer, the majority of which I was unsure about. In any case, I exported a version with everything intact (screws, jacks, knobs) and one with all of that stuff removed. I also saved the screw as a separate file. I can also send you the positions of everything if that is helpful. But it may not be ...

SK.zip

Hopefully, this works ...

Thank you for letting me help with this.

JerrySievert commented 6 years ago

awesome, and no, thank you for your awesome designs!

I'll take a look, and let you know what works and what doesn't. I had started using adobe tools, and found that they didn't work correctly in rack, then switched to Inkscape, which I hate to use (I have a Mac), and then finally to writing code to build svg's, which still didn't work in rack, but after a step through Inkscape would work.

I'll figure out the process and share.

JerrySievert commented 6 years ago

awesome, and no, thank you for your awesome designs!

I'll take a look, and let you know what works and what doesn't. I had started using adobe tools, and found that they didn't work correctly in rack, then switched to Inkscape, which I hate to use (I have a Mac), and then finally to writing code to build svg's, which still didn't work in rack, but after a step through Inkscape would work.

I'll figure out the process and share.

jonheal commented 6 years ago

By the way, when I opened your knob in Designer, the inner circle was duplicated. Two of 'em on top of each other. In my files, I deleted one of them.

JerrySievert commented 6 years ago

yup, you can thank Inkscape for that - and that was after cleaning up the mess that Inkscape made of the source svg (which was just a polygon, rect, and circle)

JerrySievert commented 6 years ago

example of the code that built them:

var draw = SVG(document.documentElement).size('10mm', '10mm').fill('#000');
var outer_knob = draw.polygon(polygon.to_svg_string(polygon.calculate(20, 20, 12, 10)));
outer_knob.move(0, 0).fill('#000');
var red_knob = draw.polygon(polygon.to_svg_string(polygon.calculate(15, 15, 12, 7.5)));
red_knob.move(2.5, 2.5).fill('#f30000');
var inner_knob = draw.circle(13).move(3.25, 3.25).fill('#c00000');
var edge = draw.rect(2, 7).fill('#000000').move(8.75, 1);

polygon is a helper method that generates a polygon - not much to mess up even :/

JerrySievert commented 6 years ago
screen shot 2018-05-11 at 12 55 03 pm

heh, here it is with only changing out the SVG - I'll run it through Inkscape and see if there's any change.

JerrySievert commented 6 years ago

hm. nothing I'm doing is getting it to work in rack - you can see for yourself by opening the plugins directory for rack, and replacing SynthKit/res/RotatingClockDivider.svg - any ideas?

jonheal commented 6 years ago

I will play with it in a bit.

JerrySievert commented 6 years ago

as an aside, looking at the source and it looks just fine.

JerrySievert commented 6 years ago

the good news is that once this is figured out, it should be pretty easy to get it all replaced.

jonheal commented 6 years ago

I have to take my son out for a while. When I get back, I will fool around with it.

JerrySievert commented 6 years ago

sounds good! wondering if switching to email would make more sense.

jonheal commented 6 years ago

Write me here >> jon@theheals.org

I had some success. Turned out to be a pretty easy fix.

image

bubbleandsquawk commented 6 years ago

Curious as to how this is coming along?

JerrySievert commented 6 years ago

code's all there, assets for all but one thing - you can compile yourself, or I can do a release. was waiting on the one (new) thing before getting it into rack's plugins.

JerrySievert commented 6 years ago

these are all live, closing.