search

SVModular / SynthKit

Synth Kit for VCV Rack
Creative Commons Zero v1.0 Universal
32 stars 5 forks source link

Feature request: labels on the prime and fibonacci clock dividers #8

Closed h00g closed 6 years ago

h00g commented 6 years ago

I suggest that the labels are added so that one can see on which beat each output fire. image

rossco255 commented 6 years ago

I'm a github/dev noob but here's an SVG for each that works. I've made the numerals as large as I think they can be, let me know if it's readable or not. labelledPanels.zip Just replace the files in /Plugins/SynthKit/res

h00g commented 6 years ago

I could probably help you update the repository but I do not have access to create a branch.

GitHub in particular is a bit new to me but doftware configuration management is a field I generally fell confident in.

h00g commented 6 years ago

This is the issue I encounter. image

h00g commented 6 years ago

You could try adding me as collaborator if the current setting is "Restrict editing to collabors only". image image image

JerrySievert commented 6 years ago

sorry @h00g, I'm not giving write access unless someone has already contributed and made substantial additions. you're welcome to create a Pull Request, which will allow for discussion, and decisions to be made though! that's the typical way to contribute with GitHub.

please note, though, if the font doesn't match, I'm likely not going to accept the PR.

as an aside, what @rossco255 was suggesting is to save the svg to your local plugins directory, and override your local copy, not to make an update to the repository itself.

rossco255 commented 6 years ago

Font used is Audiowide Regular, so should be same as the rest of the modules

h00g commented 6 years ago

Thanks for the info and maybe it's better that @rossco255 makes the pull request since I just made the suggestion to add digits and presented the Photoshop mock up.

It would be interesting to hear if you liked the suggestion conceptually @JerrySievert

JerrySievert commented 6 years ago

conceptually, I'm just fine with it - I had been developing modules so quickly that I put together a quick template and kept reusing it. as long as it matches, and looks good, I'm likely to accept the PR.

if I don't like it, I'll probably ask for some sort of change, but that's part of what the commenting part of a PR is all about.

just note, I've updated the modules to 0.6.0 to get ready for the release, so any changes won't take affect until the new rack release.

rossco255 commented 6 years ago

I've created a pull request for this, as well as including the different rotating clock behaviour I suggested here last month. This is my first time programming anything and using git, feel free to let me know of any errors or bad etiquette!

JerrySievert commented 6 years ago

closing as this is merged.