Closed Vishnurr2k01 closed 3 years ago
i have added a new problem in basics namely factorial.java
Hey, you added the commit hashcode instead of the program. Can you check that and update the URL?
Sorry , iam new to github and this is my first project.I will try to correct that.. Thank you
On Sun 11 Oct, 2020, 11:52 AM Vijay, notifications@github.com wrote:
Hey, you added the commit hashcode instead of the program. Can you check that and update the URL?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SVijayB/JavaSpace/pull/15#issuecomment-706656919, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARIF7TP5QA2KZ32W4A6LDRLSKFFMDANCNFSM4SLDARBA .
OK bro...I will update it as soon as possible Thank you
On Sun 11 Oct, 2020, 11:57 AM Vijay, notifications@github.com wrote:
@SVijayB requested changes on this pull request.
In README.md https://github.com/SVijayB/JavaSpace/pull/15#discussion_r502872271:
@@ -47,6 +47,7 @@ Basics of Java are covered within these programs.
• Sorting.java | Sorting N numbers.
• Squares.java | Print squares until N'th turn.
• Tables.java | Print Multiplication table.
- < a href="https://github.com/SVijayB/JavaSpace/commit/b5c371a9ceeb2795d98eb315afb79459f785b9fb">factorial.java| find factorial of a number
Here, you just need to update the URL to https://github.com/SVijayB/JavaSpace/blob/master/Basics/factorail.java.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SVijayB/JavaSpace/pull/15#pullrequestreview-506147676, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARIF7TPCJOG3W3ONJEUISRTSKFF37ANCNFSM4SLDARBA .
I have created a pull request with above changes Thankyou
On Sun 11 Oct, 2020, 11:58 AM Vishnu R, vishnurr2k01@gmail.com wrote:
OK bro...I will update it as soon as possible Thank you
On Sun 11 Oct, 2020, 11:57 AM Vijay, notifications@github.com wrote:
@SVijayB requested changes on this pull request.
In README.md https://github.com/SVijayB/JavaSpace/pull/15#discussion_r502872271:
@@ -47,6 +47,7 @@ Basics of Java are covered within these programs.
• Sorting.java | Sorting N numbers.
• Squares.java | Print squares until N'th turn.
• Tables.java | Print Multiplication table.
- < a href="https://github.com/SVijayB/JavaSpace/commit/b5c371a9ceeb2795d98eb315afb79459f785b9fb">factorial.java| find factorial of a number
Here, you just need to update the URL to https://github.com/SVijayB/JavaSpace/blob/master/Basics/factorail.java.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SVijayB/JavaSpace/pull/15#pullrequestreview-506147676, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARIF7TPCJOG3W3ONJEUISRTSKFF37ANCNFSM4SLDARBA .
Issue solved at #16
Description
Related Issue
This PR closes #
Motivation and Context
Screenshots (if any)
Types of changes
Checklist: