Closed jsmith closed 7 years ago
Ok an instructor can now edit their templates! I'll add some comments throughout the PR
Hey @jacsmith21 , in the issue description, can you provide step by step instructions on how to view/test the changes you've made? For some reason, after I create a course and go to http://localhost:8080/courses/{course_id_here}, im just getting a JSON: {"id":1,"name":"test","rows":5,"cols":5,"seats":[]}
. No grid view, and I'm not sure what I'm doing wrong :p
Oh yeah sorry about that, I'll update the PR description. The reason that was happening is that I created a few RESTful endpoints for courses!
Ok now I can get to the grid view. Sweet. I do see one issue though;
When I visit http://localhost:8080/instructor/1
and go to click on a link in the course list, I get a 404 because it's trying to navigate to http://localhost:8080/instructor/courses/1
Oh nice, I'll fix that bug!
@brandon1024 The list of TODOs has been finished!
@jacsmith21 Reviewing
@jacsmith21 Looks great! The only issue I see is that when you are in http://localhost:8080/instructor/coursename
, theres no way to get back to the instructor view. Maybe make the navbar Attendance Tracker
text a link to http://localhost:8080/instructor/
? Once this is working, good to merge!
Added those changes 👍
This PR resolves #22 This PR resolves #7
This PR implements the template editor. An instructor can now edit their template and set seats available / closed / reserved.
To make this all work, I added several RESTful endpoints. The full list of new endpoints includes:
/instructor/{courseName}/{courseSection}
: This is the view page where an instructor can edit their course template/courses
: Retrieves all of the courses/courses
: Insert or update a course/courses/{id}/seats
: Insert or delete a particular course's seats/course/{id}
: Retrieve a particular courseA few things that still need to be fixed are:
intructor/{courseName}/{section}