SWE-4103-Group-3 / Project

https://unbtracker.herokuapp.com/
The Unlicense
5 stars 0 forks source link

SWE22 Template Editor #48

Closed jsmith closed 7 years ago

jsmith commented 7 years ago

This PR resolves #22 This PR resolves #7

This PR implements the template editor. An instructor can now edit their template and set seats available / closed / reserved.

To make this all work, I added several RESTful endpoints. The full list of new endpoints includes:

A few things that still need to be fixed are:

jsmith commented 7 years ago

Ok an instructor can now edit their templates! I'll add some comments throughout the PR

brandon1024 commented 7 years ago

Hey @jacsmith21 , in the issue description, can you provide step by step instructions on how to view/test the changes you've made? For some reason, after I create a course and go to http://localhost:8080/courses/{course_id_here}, im just getting a JSON: {"id":1,"name":"test","rows":5,"cols":5,"seats":[]}. No grid view, and I'm not sure what I'm doing wrong :p

jsmith commented 7 years ago

Oh yeah sorry about that, I'll update the PR description. The reason that was happening is that I created a few RESTful endpoints for courses!

brandon1024 commented 7 years ago

Ok now I can get to the grid view. Sweet. I do see one issue though;

When I visit http://localhost:8080/instructor/1 and go to click on a link in the course list, I get a 404 because it's trying to navigate to http://localhost:8080/instructor/courses/1

jsmith commented 7 years ago

Oh nice, I'll fix that bug!

jsmith commented 7 years ago

@brandon1024 The list of TODOs has been finished!

brandon1024 commented 7 years ago

@jacsmith21 Reviewing

brandon1024 commented 7 years ago

@jacsmith21 Looks great! The only issue I see is that when you are in http://localhost:8080/instructor/coursename, theres no way to get back to the instructor view. Maybe make the navbar Attendance Tracker text a link to http://localhost:8080/instructor/? Once this is working, good to merge!

jsmith commented 7 years ago

Added those changes 👍