SWE6 Take Attendance - Githubissues

SWE-4103-Group-3 / Project

https://unbtracker.herokuapp.com/

The Unlicense

5 stars 0 forks source link

SWE6 Take Attendance #81

Closed jsmith closed 6 years ago

jsmith commented 6 years ago

Taking Attendance

fixes #6 fixes #75 fixes #76

Changes Proposed in this Pull Request:

Frontend logic so that instructors can take attendance
Backend controller method to process the absent students
A few other small issues (index button size, BadRequestException code)

brandon1024 commented 6 years ago

These changes look good to me :) @jacsmith21 can you fix the merge conflicts?

jsmith commented 6 years ago

Sure I'll fix those tonight!

mwalz1 commented 6 years ago

@jacsmith21 Should we make an absence entry unique through its: date, course_id & student_id? Re-submitting attendance creates a lot of duplicate entries in our database.

jsmith commented 6 years ago

@mwalz1 I'm not sure, is that a strict requirement from Dr. MacIsaac? It wouldn't be too hard to implement

jsmith commented 6 years ago

Hey, so there are a few more requirements being implemented for tomorrow:

When an instructor submits attendance more than one time per day, it will replace whatever is in the database
After an instructor submits their attendance, they should be able to see the attendance statuses until the following day

jsmith commented 6 years ago

I will be pushing changes within the next hour or two!

jsmith commented 6 years ago

I've been testing this extensively and do not see any more bugs