Searching for time should take ranges into account.

[onatbas]

Given there's a listory with a timeInfo ranging between 2000 and 2010 When a user sends in a keyword such as 2005 Then the listory with a timeInfo ranging between 2000 and 2010 should also be found and returned.

Please see the comments on searching on issue #59

Please revisit the algorithm such that if a listory has more than one timeInfo fields, it should check for this behaviour (see pseudo code):

if  timeInfo.valueCount > 1 and keyword.isdigit() and keyword bigger than value_1 && keyword smaller than value_2
        then SUCCESS

[ecada]

My last pull request offers a solution to this problem. I will really appreciate if you just take a quick look and offer your thoughts on it.

[onatbas]

There is no code to address this pushed to the repository.

I have reviewed the code, tested with it and gave you my feedback, but your response was to deny them and say "no it's not like that". I'll not pursue the merge on this branch furthermore as i see little opportunity there.

Onat Bas

On 6 Jan 2018 23:48 +0300, ecad notifications@github.com, wrote:

My last pull request offers a solution to this problem. I will really appreciate if you just take a quick look and offer your thoughts on it. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[ecada]

I've created a new pull request that addresses the issue on a brand new branch and I've tested it on my localhost.

[ecada]

I would really appreciate if you check #78 on this issue.