Closed sleepy-evelyn closed 4 years ago
Really two seperate issues here, filtering breaking searching by chef and dietary options not populating home screen queries. I can fix the searching for chef quickly that’s just the case of removing the searchable attributes from the query in searchQuery.java.
The other has nothing to do with searching and will take slightly longer.
On Fri, 29 May 2020 at 01:14, profjb58 notifications@github.com wrote:
How to replicate
- Set any dietary option or allegern option to true in the profile settings
- Log out and log back in again (Recipe info screen currently not updating correctly as well)
- Top picks and trending will be missing & searching will be impossible.
Assuming something in the more recent branches has broken this functionality. Filters also shouldn't ever effect the ability to search for a chef.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/SWEngGroup4/scranplan/issues/111, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABEOK5AVMNDPGGTHIU4YG5DRT347XANCNFSM4NNST3VQ .
Just so peeps know what i'm on about with the scrollviews failing. UserInfoPrivate data is correctly being sen't back, I have tested it using a debugger on master and this is a non-issue. It's how this mUser collection is being handled thats the issue.
fyi don't have to log out to reproduce, go to public profile then back again after making settings changes
Sorted now, was just Firebase composite indexes for the new rating names
Re opening until it gets closed with a pull request
fair one but should be fixed on all branches as was backend issue
Oh right didn’t realise that. You’re totally okay to close it 🙂
How to replicate
Assuming something in the more recent branches has broken this functionality. Filters also shouldn't ever effect the ability to search for a chef.