search

SWEngGroup4 / scranplan

Scran Plan Android Cooking App
http://scranplan.xyz
0 stars 0 forks source link

C26 messaging #121

Closed nathanbillis closed 4 years ago

nathanbillis commented 4 years ago

Adding messaging, putting into PR so it can be reviewed because I'm not very happy with it, so would be great to hear feedback/people change it as needed.

@profjb58 can you check this over for design issues

nathanbillis commented 4 years ago

Could do with some text saying what each view represents. e.g. 'Recieved Messages' and 'Send to...' Some formatting issues when sending a message to another user with a large bar at the bottom of the screen. image Other than that, looks neet. I am getting a 'deleted_user' thing. If messages are kept after a user deletes an account this needs to be stated in the privacy statement or the users ability to access them needs to be prevented. image

understood. please can suggest ways to improve the design eg. where the placement of the text would look the best? thanks

sleepy-evelyn commented 4 years ago

Placement of the Description for what each screen should be should be above all the users displayed at the top.

Best description would likely be 'Messages' - For the posts recieved. Figured this should be in quite a large font. Look a bit like spotifys headers. Probably not as big because spotifys headers are insanely large but like a kind of mid point. 'Send a Message' - Again at the top. Same font,

image

As for the banner for each user, if possible and if they have a public account enabled as a boolean value might be good to include the about me section for there profile in a smaller font below the username just to fill the space out a bit.

nathanbillis commented 4 years ago

https://trello.com/c/ha2fppWA/46-c26-social-as-a-user-i-want-to-be-able-to-send-my-friends-messages-and-recipes-so-they-can-share-in-the-ones-i-enjoy

sleepy-evelyn commented 4 years ago

Sorry to be a pain Nathan. Was looking through again and spotted some other things. The changes look great though.

image Get a white bar on top when opening someones post.

Get a blank post sometimes. image Not sure why this happens. This might be because you where sending test messages between michlondon and yourself.

nathanbillis commented 4 years ago

White bar don’t know how to fix without a full rewrite. Don’t know how to debug blank posts

On Sat, 30 May 2020 at 17:13, profjb58 notifications@github.com wrote:

Sorry to be a pain Nathan. Was looking through again and spotted some other things. The changes look great though.

[image: image] https://user-images.githubusercontent.com/46009144/83333514-b2665100-a298-11ea-8937-f52e70da04ef.png Get a white bar on top when opening someones post.

Get a blank post sometimes. [image: image] https://user-images.githubusercontent.com/46009144/83333532-cca02f00-a298-11ea-8aab-418fda667781.png Not sure why this happens.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/SWEngGroup4/scranplan/pull/121#issuecomment-636352254, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABEOK5B7IFFW7O5BU52TP53RUEWDHANCNFSM4NOT7NCQ .

sleepy-evelyn commented 4 years ago

Also, another bug I found is this thing.

image When you post to someone and then return back to the recent posts page you get this design error. It returns back to normal when entering the recent posts page again.

sleepy-evelyn commented 4 years ago

Also, another bug I found is this thing.

image When you post to someone and then return back to the recent posts page you get this design error. It returns back to normal when entering the recent posts page again.

If your short on time, i'm guessing this bug would be the priority.