search

SWEngGroup4 / scranplan

Scran Plan Android Cooking App
http://scranplan.xyz
0 stars 0 forks source link

Fix profile #112 #125

Closed louisifn closed 4 years ago

louisifn commented 4 years ago

112 Fixes, some code neatening, fixes for deleted posts & some design improvements

nathanbillis commented 4 years ago

@louisifn could you either rebase or merge the master please - there’s a few conflicts and I’m not sure what’s the best way to resolve the all

louisifn commented 4 years ago

Will do

sleepy-evelyn commented 4 years ago

Am I ok to append to this branch and finish it as well Louis before you merge. Need to update the privacy collections really with the new privacy stuff and get rid of some unused code. Also need to check and re-write tests based upon content displayed.

louisifn commented 4 years ago

@profjb58 yeah mate will just push the pull from master

louisifn commented 4 years ago

added a fix for all post deletion, there was an error in logic. Recipes on profiles on click has been disabled accidentally in one of the merges so this was readded

sleepy-evelyn commented 4 years ago

Fixed pretty much everything except for the issue where it crashes between switching to the image tab on another persons profile and the followers issue where it goes to -1. I need to re-write tests for this since i've added new functionality and modified some that currently exists. ETA should be tommorow. Or I guess today, it's like 00:23

louisifn commented 4 years ago

122 and #95 both fixed

louisifn commented 4 years ago

@profjb58 can you make it so it auto loads on the private tab, please

louisifn commented 4 years ago

it would appear that the issue " switching to the image tab on another persons profile" has been added from your push to this branch