SWEngGroup4 / scranplan

Scran Plan Android Cooking App

http://scranplan.xyz

0 stars 0 forks source link

changes onResume in home - shared preferences was now working #157

Closed louisifn closed 4 years ago

louisifn commented 4 years ago

getSharedPreferences no longer used - not sure if these were ever working? loadSearchOptions() is now never called and storeSearchOptions() & resetFilters() seem to only be used in tests?

sleepy-evelyn commented 4 years ago

? The shared preferences is a fix I added for when search options reset when going to an activity. They should work. I'm not sure why they aren't. Might be because they haven't been initialized

louisifn commented 4 years ago

155 fix

sleepy-evelyn commented 4 years ago

Removing shared preferences will re-introduce the bug whereby filters reset when visiting an activity so it's worth keeping them and figuring out why they are not working.

sleepy-evelyn commented 4 years ago

Yeah i've tested on the main branch, It all seems to work.

sleepy-evelyn commented 4 years ago

From Becky. remove translucency for create recipe button.