SWFSC / eSDM

A user-friendly spatial tool with a web-based interface that allows users to import SDM layers and create and explore ensemble predictions to inform management and explore spatial uncertainties
https://swfsc.github.io/eSDM/
Apache License 2.0
11 stars 4 forks source link

upcoming sf breaks a test in eSDM #17

Closed edzer closed 1 month ago

edzer commented 3 months ago

Please see https://github.com/r-spatial/sf/issues/2378 : this breaks tests in eSDM:

  Running ‘testthat.R’
 ERROR
Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
  [ FAIL 2 | WARN 4 | SKIP 0 | PASS 40 ]

  ══ Failed tests ════════════════════════════════════════════════════════════════
  ── Failure ('test-overlay_sdm.R:25:3'): simple overlay ─────────────────────────
  overlay_sdm(sfc2, sf1, 1, 100) not equal to `sf2`.
  Attributes: < Component "class": Lengths (4, 2) differ (string compare on first 2) >
  Attributes: < Component "class": 1 string mismatch >
  ── Failure ('test-overlay_sdm.R:26:3'): simple overlay ─────────────────────────
  overlay_sdm(sfc2, sf1b, 1, 100) not equal to `sf2b`.
  Attributes: < Component "class": Lengths (4, 2) differ (string compare on first 2) >
  Attributes: < Component "class": 1 string mismatch >

  [ FAIL 2 | WARN 4 | SKIP 0 | PASS 40 ]
  Error: Test failures
  Execution halted

we now have

> class(overlay_sdm(sfc2, sf1, 1, 100))
[1] "sf"         "tbl_df"     "tbl"        "data.frame"

please correct and resubmit to CRAN.

edzer commented 1 month ago

The sf release that breaks eSDM can be expected on CRAN any moment now.