search

SWG-Source / dsrc

Other
11 stars 50 forks source link

Tie Interceptor / Advanced Stuck In The Ground At Space Ports #123

Closed Namsemag closed 4 years ago

Namsemag commented 4 years ago

A tie advanced keeps getting "stuck" into the ground in start ports, you can't select it and it doesn't move nor does it have collision screenShot0123 screenShot0122 screenShot0092

IrishDarkshadow commented 4 years ago

The TFE guys had a similar issue and it turned out to be an entry in the Oracle database that was spawning the ship. I wasn't able to reproduce the issue on the QA server or a master branch VM.

Namsemag commented 4 years ago

Right any idea where to start to look for the reason?

IrishDarkshadow commented 4 years ago

Three recent pieces of information on this one:

(1) god client cannot target the Tie to get spawn info from it (2) it only appears when a city / region flips to Imperial GCW control (3) as it has no OID, the suspicion is that it might be a client effect for flyby traffic that is spawning in the wrong place

IrishDarkshadow commented 4 years ago

Some progress made on this one. GrandMasterVader noticed that the TIE appears in cities with starports that become Imperially aligned.

On the QA server I set up a city outside Mos Espa, aligned it Imperial, set to region defender, ran a couple of imperial terminal missions and left everything for a couple of hours. When I logged back in the region had gone 100% imperial: image

Upon visiting the starport in Mos Espa you then see this: https://youtu.be/-LntI-B1C8c

The other starports on Tatooine are completely clear of TIEs and all are at 50 / 50 GCW region score.

I'd say that proves that we're dealing with something spawned via the GCW region defense system.

Cekis commented 4 years ago

This is likely the flyby file then that is causing the TIE to show up in the middle of the starport. The file is spawned based on faction alignment... If it is only showing up when imperial control is in place then this file is spawned:

object/static/structure/general/distant_ship_controller_imperial.cdf

There is likely something in that chain that is putting the tie there. We know it's an aggressor, so it's likely that particular model in that CDF which is not being assigned the correct aspect of "flying by".

IrishDarkshadow commented 4 years ago

The original report of this was a TIE Interceptor, the first pic in this bug report is a TIE Advanced and the current one in Mos Espa on the QA Server is an Interceptor too.

Did you get an Aggressor to spawn somewhere else?

Cekis commented 4 years ago

The best way to test this is to spawn that IFF somewhere alone (i.e. out in the desert) and see if the tie shows up at the spawn point. If it does, then yeah, the CDF needs fixed.

IrishDarkshadow commented 4 years ago

Used this: /object spawn object/static/structure/general/distant_ship_controller_imperial.iff

Produced this: image

IrishDarkshadow commented 4 years ago

The fix to this issue is in this commit: https://github.com/SWG-Source/client-assets/commit/ef3dc694d2b120b20f0aa8c03e013fe9755ea90a

The appearance file for the imperial controller had mismatched entries in it for the skeletion and animation table (skt / lat) related to the TIE Interceptor. It was originally using distant_tie_interceptor and distant_tie_interceptor1 in the SKTI chunk but the LATX chunk was using distant_tie_interceptor1 and distant_tie_interceptor2. Changing those two chunks so that they match up stops the half buried ship from appearing in the center of a starport that is in an Imperial controlled GCW region.

I watched the air traffic after applying this fix and was able to observe every combination of ships attached to the controller except for a single TIE Interceptor....the double and triple formations showed up multiple times. That may result in a following on issue to be solved but for now, this fix corrects the reported issue.