search

SWI-Prolog / contrib-protobufs

An interface to Google Protocol Buffers (protobuf)
8 stars 7 forks source link

Oneof is not properly supported (also map?) #11

Closed kamahen closed 3 years ago

kamahen commented 3 years ago

Currently, the oneof option is skipped, resulting in incorrect processing for the overlaid fields.

Need test cases (the "golden" message isn't sufficient).

This probably also applies to map.

kamahen commented 3 years ago

"Oneof" now works. Some checks are missing, but it should be good enough. https://github.com/SWI-Prolog/contrib-protobufs/commit/c8b481c7e2556557adb2f4ef5054525375a3f7b8

"Map" is a different problem, so I'm opening a separate issue for it.