search

SWI-Prolog / packages-http

The SWI-Prolog HTTP server and client libraries
23 stars 23 forks source link

fix append argument order in auth_expansion #138

Closed wdiestel closed 4 years ago

wdiestel commented 4 years ago

authentication did not expand the request because the append in auth_expansion failed (wrong argument order)

wdiestel commented 4 years ago

This bug appeared first when I updated from 7.x to version 8.0.2. The legacy authentication handler is executed but adding it's output to the request structure fails because of the wrong argument order. This issue was discussed here also: https://swi-prolog.discourse.group/t/custom-http-authenticator-failing-after-upgrading-to-v8-0-3/1379

It would be good to merge it into the stable branch as well. Meanwhile the workaround from the forum post could be used to overwrite the default expansion hook.

JanWielemaker commented 4 years ago

Thanks. Merged after changing the commit message header to FIXED: to make it appear in the change log.