SWI-Prolog / packages-http

The SWI-Prolog HTTP server and client libraries
23 stars 23 forks source link

GraphQL interface #153

Closed eshelyaron closed 2 years ago

eshelyaron commented 2 years ago

This PR adds the following:

If the API looks alright, I'll work on a more comprehensive test suite, at least for the reader/writer parts.

JanWielemaker commented 2 years ago

Thanks! Looks mostly good. I propose to put the whole thing into one file though. It is small enough and a single file is simply easier to manage. Some other points:

Now need to do some cooking :smile:

eshelyaron commented 2 years ago

Thanks for the swift review! I had a misconception that some non-default flag was required for "a" literals in DCGs, that's good to know. I've addressed the above points in the latest commit https://github.com/SWI-Prolog/packages-http/pull/153/commits/8eab5291976ce42593a5fc15315d6510412f42f4.

JanWielemaker commented 2 years ago

Thanks for all the updates. Made two more changes, re-running the dependencies (I saw some calls colored indicating they still needed unspecified autoloading), removed the asserts for paths in the test files. You find these in many places, but they are no longer needed since the move to CMake.

Finally squashed the branch. As this is the first release, the history is irrelevant.

Note that you can use PceEmacs or gxref/0 to find remaining autoload issues. Another option is to load the test file, disable autoloading and run the tests.