SWI-Prolog / packages-http

The SWI-Prolog HTTP server and client libraries
23 stars 23 forks source link

Don't reuse original test port for HTTP proxy #165

Closed brebs-gh closed 7 months ago

brebs-gh commented 7 months ago

Instead, use port assigned by OS.

Intention is to prevent intermittent build test failure on Linux armv7, and Mac M1.

The HTTP, HTTPS, SOCKS and "unused" ports are still reused, though.

Original build failure report: https://swi-prolog.discourse.group/t/swi-prolog-9-2-2-fails-http-proxy-test-on-armv7/7275

JanWielemaker commented 7 months ago

This pull request has been mentioned on SWI-Prolog. There might be relevant details there:

https://swi-prolog.discourse.group/t/swi-prolog-9-2-2-fails-http-proxy-test-on-armv7/7275/5

JanWielemaker commented 7 months ago

Thanks! Merged after tagging the commit with TEST:. Ran the tests in a loop for a while on the M1 and all passed. Could be luck, but seems promising :smile: