search

SWI-Prolog / packages-jpl

JPL: The Prolog <-> Java interface
BSD 2-Clause "Simplified" License
52 stars 32 forks source link

Downgraded small code to Java 1.7 for compatibility (removed lambda) #74

Closed ssardina closed 4 years ago

ssardina commented 4 years ago
JanWielemaker commented 4 years ago

Thanks. Branch wasn't in sync, so I cherry-picked the relevant commit. Release build works again :)

ssardina commented 4 years ago

Great. Yes I thought about it. I did some doc pushes to master after that branch.

I thought about re-basing the branch (and re-push it with --force) but I thought that GitHub allows you to do a REBASE+MERGE in the PR from the GUI itself, right? I though you were going to do so, to keep a linear history.

JanWielemaker commented 4 years ago

I often prefer to do the merge locally, so I can test before pushing. A rebase would probably have worked too. Anyway, we are getting close. Thanks.

ssardina commented 4 years ago

OK cool, I get it. Makes sense, you check everything locally and then push. Good.

BTW, you must have seen that now that the repo is Maven-based, I set-up GitHub to compile automatically when pushing to master or PR to master.

I also set-up packaging in GitHub so one could easily get the latest Java API via Maven dependency automatically (as the Java API is expected to change much more than the C infrastructure) by just following instruction shere:

https://jpl7.org/DeploymentJava

All good, it is looking better and easier to use. I would just love to know who is using SWIPL via JPL, there seems to be more people than what I thought...

JanWielemaker commented 4 years ago

I would just love to know who is using SWIPL via JPL, there seems to be more people than what I thought...

I have little clue. Breaking JPL causes people to complain though :smile: Many people seem to like embedding Prolog into something. I'm not a fan of it.

ssardina commented 4 years ago

Are you suggesting an effective way to find out who is using JPL? Sounds good, I can do that easily! ;-)

I understand why you are not a fan of it. :-)

But I could see why people would like to use Prolog embedded. And Java is a very popular and mainstream language, in which an embedded Prolog section could make parts of the app much nicer, simpler, and maintainable.

That's why I wanted to get JPL to an easily accessible framework. It could be a very powerful combination.