SWI-Prolog / swipl-devel

SWI-Prolog Main development repository
http://www.swi-prolog.org
Other
976 stars 176 forks source link

test_interrupt: skip test if prolog_alert_signal = 0 #1279

Closed mgondan closed 5 months ago

JanWielemaker commented 5 months ago

Why did you close this? Note that it is broken as prolog_alert_signal/2 is not defined on all platforms (notably not on Windows). So, we should not run the test if this predicate is defined and prolog_alert_signal(0, 0) succeeds. If this predicate is not defined we assume there is some other mechanism to make this work.

mgondan commented 5 months ago

Ah, ok. I wasn't aware of this. Is an additional current_predicate needed? I'll reopen it in the afternoon

JanWielemaker commented 5 months ago

I'm happy to adjust the PR. I was more wondering whether the PR had become irrelevant for some reason. If it is still relevant, I can deal with it.

mgondan commented 5 months ago

All right. Thanks. No, it's not irrelevant.

JanWielemaker commented 5 months ago

Ok. Updated to 30fae0a22e871525e1cd8ba2bd640cf77e5994ba