search

SWI-Prolog / swipl-devel

SWI-Prolog Main development repository
http://www.swi-prolog.org
Other
954 stars 172 forks source link

TEST: prevent ASAN breaking sanity check #1319

Closed kamahen closed 2 weeks ago

JanWielemaker commented 2 weeks ago

This does not really seem to be the right way to fix as we still get negative stack sizes. The real seems to be that this way to check for stack overflows does not work with ASAN (though I do not see any errors so far).

Anyway, the entire function is disabled by 

  #if O_PLMT && !defined(__SANITIZE_ADDRESS__)

Is that not set for some reason for you? It should be set by GCC AFAIK and it is set in pl-incl.h for clang, which does it differently.

kamahen commented 2 weeks ago

I ran across this a while ago (not sure when) but didn't submit it as a PR -- your #if O_PLMT && !defined(__SANITIZE_ADDRESS__) might have been done after my quick "work-around". (It's also possible that I set the flags wrong in my build.)

Deleting this PR.