Victor's version of swiftsim_pr

SWIFTSIM / HBTplus

HBTplus halo finder adapted for the FLAMINGO and COLIBRE simulations

0 stars 0 forks source link

Victor's version of swiftsim_pr #1

Closed VictorForouhar closed 5 months ago

VictorForouhar commented 5 months ago

Merging my latest version of HBT+, which was tested on COLIBRE outputs. We should establish the minimum working version before continuing development/bug fixes. Main differences respect to master:

Different OMP reduction fix (which one is best?)
Automatic loading of BoxSize from swiftsim outputs
TODO list summarising identified working points.

jchelly commented 5 months ago

Thanks Victor. I'll take a look at this now.

VictorForouhar commented 5 months ago

Based on the discussion on BoxHalf being set before we overwrite the value of BoxSize based on swiftsim snapshots, another derived parameter is also not being updated: TreeNodeResolution = SofteningHalo * 0.1. Consequently, TreeNodeResolutionHalf is also out of date.