search

SWIFTSIM / HBTplus

HBTplus halo finder adapted for the FLAMINGO and COLIBRE simulations
0 stars 0 forks source link

Consider subhalos to be disrupted if they contain too few collisionless particles #10

Closed jchelly closed 4 months ago

jchelly commented 5 months ago

This adds a new parameter MinNumTracerPartOfSub which determines the minimum number of particles of the types specified in TracerParticleTypes which must be bound to a subhalo for it to be considered resolved. Subhalos are only resolved if they contain at least MinNumPartOfSub total particles AND at least MinNumTracerPartOfSub "tracer" type particles.

jchelly commented 5 months ago

Here's a plot showing the mass function in a small test run with MinNumPartOfSub=20 and MinNumTracerPartOfSub=0,10,100. mass_function_n_gt_0

jchelly commented 5 months ago

If I compare between master and this branch with MinNumTracerPartOfSub=0 there are some tiny differences in the mass function. I'm not sure if that is due to non-reproducible rounding error in the threaded parts of the code, the random sampling in the unbinding or something else.

jchelly commented 5 months ago

I'm also a little surprised that there's so little difference between requiring 0 tracer particles and requiring 10.

robjmcgibbon commented 5 months ago

Could you please add an flamingo/colibre parameter file to the configs directory? Now that new parameters are being added it would be good to have an example to refer to so we don't forget to set any values

robjmcgibbon commented 4 months ago

Thanks, looks good to me!