search

SWIFTSIM / HBTplus

HBTplus halo finder adapted for the FLAMINGO and COLIBRE simulations
0 stars 0 forks source link

Add MaxNumPartMerge parameter #13

Closed robjmcgibbon closed 3 months ago

robjmcgibbon commented 4 months ago

For large halos it might be beneficial to consider more than just the 20 most bound particles when determining mergers. This PR introduces a new parameter MaxNumPartMerge. When determining the position and velocity of a subhalo, both satellites and centrals, min(Nbound, MaxNumPartMerge) will now be used instead of 20 every time.

TODO

jchelly commented 4 months ago

If this is set large then I think there's a danger that ComovingSigmaR will just reflect the size of the halo, when what we really want is an uncertainty on the positions due to the limited resolution of the simulation so we can determine if the satellite and central halo positions are indistinguishable. If that happens I guess we'll see fewer satellites in the output due to increased merging.

robjmcgibbon commented 3 months ago

Closing this for the time being, I don't think we have any good reason to change it