Avoid integer overflow setting SinkTrackId

SWIFTSIM / HBTplus

HBTplus halo finder adapted for the FLAMINGO and COLIBRE simulations

0 stars 0 forks source link

Avoid integer overflow setting SinkTrackId #43

Closed jchelly closed 1 week ago

jchelly commented 1 week ago

On the FLAMINGO 10k run TrackIds exceed the maximum value of an int, and there's an instance in the code where SinkTrackId is stored as an int rather than a HBTInt so the value overflows.

jchelly commented 1 week ago

In the affected 10k outputs this can be corrected by adding 2^32 to SinkTrackId in cases where SnapshotIndexOfSink>=0 and SinkTrackId<0.