search

SWIFTSIM / SWIFT

Modern astrophysics and cosmology particle-based code. Mirror of gitlab developments at https://gitlab.cosma.dur.ac.uk/swift/swiftsim
http://www.swiftsim.com
GNU Lesser General Public License v3.0
88 stars 58 forks source link

Fixes for test suite on ARM64 #19

Closed dacreman closed 3 years ago

dacreman commented 3 years ago

This PR fixes the test suite when run on the Isambard ARM64 system. There are two types of change: firstly change any remaining clock ticks into human readable format, and secondly running the formatter. With these changes the test suite passes with both the GNU and ARM/Allinea compilers.

When running the test suite load the same modules used to build SWIFT and also the cray-python module. Pip install h5py (with the --user flag) to get testReading.sh to pass. To get testFormat.sh passing set the CLANG_FORMAT_CMD environment variable using

export CLANG_FORMAT_CMD=/opt/cray/pe/cce/11.0.4/cce-clang/aarch64/bin/clang-format

MatthieuSchaller commented 3 years ago

I have pushed the changes to the test timers to the master code. The github version should already be up-to-date.

The formatting changes, I won't push now as they would break our automated tests since these use clang 10 and not clang 11. Annoyingly, tiny formatting changes occur between versions. We'll likely move to a newer clang soon though.

MatthieuSchaller commented 3 years ago

All the changes have been included (see #18). The remaining formatting differences will not be updated at this stage.