SWIFTSIM / SWIFT

Modern astrophysics and cosmology particle-based code. Mirror of gitlab developments at https://gitlab.cosma.dur.ac.uk/swift/swiftsim
http://www.swiftsim.com
GNU Lesser General Public License v3.0
88 stars 58 forks source link

HM80 ice sitting on HM80 hydrogen helium in giant impact simulations #28

Closed joe637 closed 2 years ago

joe637 commented 2 years ago

I am currently running giant impact simulations of an icy object impacting on a Uranus-like ice giant planet using the equations of state of Hubbard and Macfarlane (1980). However, whenever I try to run this in SWIFT, it seems to leave a layer of the impactor ice on top of the hydrogen helium atmosphere of the ice giant. This clearly isn't a physical result. I have checked the mass of the impactor and target particles and they are both similar enough such that this shouldn't be a problem, but it still seems to be happening. Do you have any suggestions on what I could change to remove this problem

https://user-images.githubusercontent.com/88051094/157776973-ff0e5771-6321-4277-9bce-6a855f21db4f.mp4

jkeger commented 2 years ago

Hi Joe, I don't remember all the details but I assume this is the issue we emailed about at the time, which we decided wasn't an actual concern after all?

joe637 commented 2 years ago

Hi Jacob, yes I think it was

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows

From: Jacob @.> Sent: 06 July 2022 23:37 To: @.> Cc: @.>; @.> Subject: Re: [SWIFTSIM/swiftsim] HM80 ice sitting on HM80 hydrogen helium in giant impact simulations (Issue #28)

Hi Joe, I don't remember all the details but I assume this is the issue we emailed about at the time, which we decided wasn't an actual concern after all?

— Reply to this email directly, view it on GitHubhttps://github.com/SWIFTSIM/swiftsim/issues/28#issuecomment-1176821809, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AU7Y3FRN3U7XECNKWGZK3P3VSYDAVANCNFSM5QOEWXGQ. You are receiving this because you authored the thread.Message ID: @.***>