search

SWIFTSIM / SWIFT

Modern astrophysics and cosmology particle-based code. Mirror of gitlab developments at https://gitlab.cosma.dur.ac.uk/swift/swiftsim
http://www.swiftsim.com
GNU Lesser General Public License v3.0
88 stars 58 forks source link

Dg filename parameter #39

Closed themkots closed 9 months ago

themkots commented 10 months ago

As I have it right now. Upon checking with --enable-debugging-checks, I get in both module scotch64 and my scotch-local builds lines like 

[0000] [00483.4] engine_repartition: repartitioning space
[0000] [00483.4] check_weights: checking vertex weight consistency
[0000] [00483.4] check_weights: checking edge weight consistency
[0000] [00483.4] check_weights: partition weights checked successfully
ERROR: graphCheck: edge load sum overflow
[0000] [00483.4] repart_scotch: SCOTCH repartition successful.
[0000] [00483.5] space_rebuild: (re)building space

probably some of my typedefs in line 55 onwards of src/partition.c are to blame .. investigating

MatthieuSchaller commented 10 months ago

If you worry about problematic overflows, you could try running with -e at runtime. This activates FPE detection.

themkots commented 10 months ago

If you worry about problematic overflows, you could try running with -e at runtime. This activates FPE detection.

Thanks. I will try with mpirun -e ... in the jobscripts

MatthieuSchaller commented 10 months ago

In case there is confusion, that's not an mpirun parameter but a swift one.

themkots commented 10 months ago

This last commit https://github.com/SWIFTSIM/SWIFT/pull/39/commits/9c55cd191c28abee0cc7a3936d3155dd91b7f733 takes care of the overflow error that was bothering me -- now scotch graphCheck does not complain about overflow in all cases checked [s32,s64,slocal]

themkots commented 9 months ago

Closing this PR as it is outdated. Will create a new PR where all the comments above have been addressed and with the latest updates.