Closed JDonaldM closed 2 years ago
Hello @JDonaldM
Thanks for the comments! It is indeed much nicer to have each page be self-consistent. I've implemented updates to these sections here: https://github.com/SWIFTSIM/emulator/pull/35 We'll merge the changes to the master once https://github.com/SWIFTSIM/emulator/issues/22 is also fixed.
Have now been resolved with #35 and #36
Review thread.
I haven't looked at at all of the examples in the docs yet but the ones I have looked at have been really nice and give a good overview of what you can do with the code!
I did want to note that in a few cases the code blocks cannot be run in the order they are presented without a couple of tweaks. For example:
matplotlib
but it isn't imported in any of the previous code blocks, also the parameter sweep plot callsschecter_emulator
which isn't defined in this example.eagle_25.yml
, it wasn't immediately clear to me where to find this file.files
andvalue_files
in the first code block are undefined, along withfilenames
in the third code block.