SWIFTSIM / emulator

The SWIFT simulation cosmological emulator (swift-emulator)
GNU Lesser General Public License v3.0
5 stars 2 forks source link

[JOSS review] Minor comments about examples in the docs. #34

Closed JDonaldM closed 2 years ago

JDonaldM commented 2 years ago

Review thread.

I haven't looked at at all of the examples in the docs yet but the ones I have looked at have been really nice and give a good overview of what you can do with the code!

I did want to note that in a few cases the code blocks cannot be run in the order they are presented without a couple of tweaks. For example:

Moyoxkit commented 2 years ago

Hello @JDonaldM

Thanks for the comments! It is indeed much nicer to have each page be self-consistent. I've implemented updates to these sections here: https://github.com/SWIFTSIM/emulator/pull/35 We'll merge the changes to the master once https://github.com/SWIFTSIM/emulator/issues/22 is also fixed.

Moyoxkit commented 2 years ago

Have now been resolved with #35 and #36