Closed kstoreyf closed 2 years ago
Thanks for the comments, will be fixed with #40
Thanks! For 3, I think you now need to call gaussian_process.GaussianProcessEmulator()
, not just GaussianProcessEmulator()
, after the import statement.
Yes indeed, has been fixed now
Part of JOSS review.
Hello, I was running the example code for the Interaction with SWIFT examples and hit a few small bugs / things that could be more self-consistent.
I believe
key: output_path / f"{key}.yml"
should be something likekey: f"{output_path}/{key}.yml"
?Just saw that this was referenced in #34 but I don't think it has been fixed.
For the example on Loading SWIFT Data, it uses the
load_pipeline_outputs
function without importing it on the page. It would be good to include the linefrom swiftemulator.io.swift import load_pipeline_outputs
Similarly, in the last code block on Loading SWIFT Data, replace
emulator = GaussianProcessEmulator()
withThanks!