search

SWIFTSIM / pipeline-configs

Configuration files for the `pipeline`, each for different simulation sub-grid models.
1 stars 9 forks source link

WIP Update the SNIa rate plots in the pipeline #242

Open Fonotec opened 1 year ago

Fonotec commented 1 year ago

This is an update that is mainly related to SNIa. Below I summarize the changes:

  1. Update the observational data repository (depends on SWIFTSIM/velociraptor-pipeline-data#115) this MR depends on @MatthieuSchaller
  2. Include where possible the corresponding data in the plots
  3. Plot the logger file for the cosmic SNIa and CC SN rate
  4. Plot the logger file for the cosmic r-processes rates (NS mergers, collapsars, CEJSN) interesting for @correac
  5. Calculate the cosmic SNIa and CC rate directly from the amount of stellar mass formed
  6. I also added a plot with the cosmic ratio of SNIa and CC SN.
  7. Divide the section of SNIa in more sections to keep a good overview. I now have sections for cosmic rates calculated from the stellar mass formed, cosmic rates from loggers, SNIa rates versus gas metallicity, SNIa rates versus SFR or sSFR, SNIa rates versus stellar mass.
  8. I reordered some plots such that the first plots that appear are the plots that we want to see first.
  9. I added a description of the SNIa model to the model description at the top of the webpage.
MatthieuSchaller commented 1 year ago

Can you also update the submodule version?

EvgeniiChaikin commented 1 year ago

Thanks @Fonotec!

Just to update you on the status: I have started looking into this PR but it will likely take me a couple of more days to finish the review.

MatthieuSchaller commented 1 year ago

Any updates on this? Note that there are merge conflicts.

MatthieuSchaller commented 1 year ago

This needs merging master into when ready.

EvgeniiChaikin commented 1 year ago

Is this ready for the second review, @Fonotec, or are you planning to make more changes?

Fonotec commented 1 year ago

I am making some more edits, I will let you know when I am done.

MatthieuSchaller commented 1 year ago

@EvgeniiChaikin are you happy with the new version?